Re: [PATCH][REGRESSION] drm: kirin: Fix drm_of_find_panel_or_bridge conversion
From: Sean Paul
Date: Tue Jun 06 2017 - 10:34:26 EST
On Fri, Jun 2, 2017 at 2:52 PM, Sean Paul <seanpaul@xxxxxxxxxxxx> wrote:
> On Fri, Jun 2, 2017 at 2:00 PM, John Stultz <john.stultz@xxxxxxxxxx> wrote:
>> On Tue, May 23, 2017 at 8:04 PM, Xinliang Liu <xinliang.liu@xxxxxxxxxx> wrote:
>>> On 24 May 2017 at 00:40, John Stultz <john.stultz@xxxxxxxxxx> wrote:
>>>>
>>>> This fixes a regression introduced by ebc944613567 ("drm:
>>>> convert drivers to use drm_of_find_panel_or_bridge") that was
>>>> recently merged, causing HDMI output to not work.
>>>>
>>>> For the kirin driver, the port value should be 1 instead of 0,
>>>> so this oneline patch fixes it and gets graphics working again.
>>>>
>>>> Cc: Rob Herring <robh@xxxxxxxxxx>
>>>> Cc: Archit Taneja <architt@xxxxxxxxxxxxxx>
>>>> Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
>>>> Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
>>>> Cc: Sean Paul <seanpaul@xxxxxxxxxxxx>
>>>> Cc: Dave Airlie <airlied@xxxxxxxxx>
>>>> Cc:
>>>> Xinliang Liu <xinliang.liu@xxxxxxxxxx>
>>>> Fix-suggested-by: Rob Herring <robh@xxxxxxxxxx>
>>>> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
>>>
>>>
>>> Looks good to me. Thanks for the patch.
>>>
>>> Reviewed-by:
>>> Xinliang Liu <xinliang.liu@xxxxxxxxxx>
>>>
>>
>> Just wanted to check in on this. Is there someone I'm missing from the
>> cc list on this?
>>
>
> Hi John,
> Apologies, I just saw this. Slipped through my cracks because it's not
> posted on dri-devel.
>
> The patch looks good. I'll pick it up in drm-misc-fixes if Dave
> doesn't take it directly into drm-fixes.
>
Hi John,
I've picked this up in drm-misc-fixes.
Thanks again for the patch,
Sean
> Sean
>
>
>> thanks
>> -john