Re: [PATCH] EDAC: mv64x60 calculate memory size correctly
From: Borislav Petkov
Date: Tue Jun 06 2017 - 12:55:42 EST
On Tue, Jun 06, 2017 at 03:07:04AM +0000, Chris Packham wrote:
> I'll wait for feedback before sending a v2.
You can't be expecting me to review PPC code reliably. :-)
AFAIR from the recent discussion, Michael said that the aim is to remove
CONFIG_MV64X60 and since this driver depends on it, that would make it
obsolete too.
But I don't think we've ever "hijacked" a driver and renamed it to be
used as a driver on a different architecture - that would be just too
unorthodox.
So if I had to decide, I'd suggest you create your own armada_edac.c or
whatever that is and put your code there. Or, if you're going to support
multiple Marvell chips, then call it mv_edac.c or marvell_edac.c or so
and start building a fine driver there.
How does that sound?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.