Re: [PATCH][V2] net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value
From: David Miller
Date: Tue Jun 06 2017 - 15:16:38 EST
From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Mon, 5 Jun 2017 10:04:52 +0100
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The current comparison of entry < 0 will never be true since entry is an
> unsigned integer. Make entry an int to ensure -ve error return values
> from the call to jumbo_frm are correctly being caught.
>
> Detected by CoverityScan, CID#1238760 ("Macro compares unsigned to 0")
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
I know Julia asked for more comments, but I'm going to apply this
as-is for now as it is correct.
Thanks Colin.