Re: [PATCH 10/16] powerpc: vio: use dev_groups and not dev_attrs for bus_type
From: Greg Kroah-Hartman
Date: Wed Jun 07 2017 - 01:46:04 EST
On Wed, Jun 07, 2017 at 09:04:41AM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2017-06-06 at 21:30 +0200, Greg Kroah-Hartman wrote:
> > >
> > > static struct device_attribute vio_dev_attrs[] = {
> > > __ATTR_RO(name),
> > > @@ -1573,6 +1576,13 @@ static struct device_attribute vio_dev_attrs[] = {
> > > __ATTR_RO(modalias),
> > > __ATTR_NULL
> > > };
> > > +static struct attribute *vio_dev_attrs[] = {
> >
> > Hm, this feels wrong, odd that 0-day passed it. I should be deleting
> > the above vio_dev_attrs field as well. Is powerpc really a dead
> > platform? :)
>
> Haha, not yet no, and the above is actually still quite actively
> in use as it's part of our hypervisor virtual IO infrastructure.
Ok, let me fix this, right after I emailed 0-day sent me the build error :)