Re: [PATCH 2/6] efi: Avoid fortify checks in EFI stub

From: Ard Biesheuvel
Date: Wed Jun 07 2017 - 04:55:02 EST


On 7 June 2017 at 03:12, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> On Tue, Jun 6, 2017 at 10:17 AM, Mark Rutland <mark.rutland@xxxxxxx> wrote:
>> On Tue, Jun 06, 2017 at 05:13:07PM +0000, Ard Biesheuvel wrote:
>>> (+ Mark, Matt)
>>>
>>> On 6 June 2017 at 04:52, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>>> > This avoids CONFIG_FORTIFY_SOURCE from being enabled during the EFI stub
>>> > build, as adding a panic() implementation may not work well. This can be
>>> > adjusted in the future.
>>> >
>>> > Suggested-by: Daniel Micay <danielmicay@xxxxxxxxx>
>>> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>>> > Cc; Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>
>>> > Cc: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
[...]
>>>
>>> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
>>>
>>> This is unlikely to conflict with anything going through the EFI tree,
>>> so feel free to queue it elsewhere.
>
> If it can go through the EFI tree, that'd be great. Less for akpm to wrangle. :)
>

That is fine, but I'd prefer not to take a single patch out of
context. Do you have a link to the entire series? I was only cc'ed on
this patch (In the future, please cc me on the entire series in cases
such as these.)