Re: [PATCH] xen/privcmd: Support correctly 64KB page granularity when mapping memory

From: Juergen Gross
Date: Wed Jun 07 2017 - 05:25:23 EST


On 31/05/17 15:03, Julien Grall wrote:
> Commit 5995a68 "xen/privcmd: Add support for Linux 64KB page granularity" did
> not go far enough to support 64KB in mmap_batch_fn.
>
> The variable 'nr' is the number of 4KB chunk to map. However, when Linux
> is using 64KB page granularity the array of pages (vma->vm_private_data)
> contain one page per 64KB. Fix it by incrementing st->index correctly.
>
> Furthermore, st->va is not correctly incremented as PAGE_SIZE !=
> XEN_PAGE_SIZE.
>
> Fixes: 5995a68 ("xen/privcmd: Add support for Linux 64KB page granularity")
> CC: stable@xxxxxxxxxxxxxxx
> Reported-by: Feng Kan <fkan@xxxxxxx>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>

Committed to xen.tip for-linus-4.12b


Juergen