Re: [PATCH 2/2] video: adp8870: move header file out of I2C realm

[Daniel Thompson]

On 21/05/17 23:09, Wolfram Sang wrote:
> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
>
> Signed-off-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>

Acked-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>

> ---
>   arch/blackfin/mach-bf537/boards/stamp.c        | 2 +-
>   drivers/video/backlight/adp8870_bl.c           | 2 +-
>   include/linux/{i2c => platform_data}/adp8870.h | 0
>   3 files changed, 2 insertions(+), 2 deletions(-)
>   rename include/linux/{i2c => platform_data}/adp8870.h (100%)
>
> diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> index 7db90c72bd8ddc..7528148dc4925b 100644
> --- a/arch/blackfin/mach-bf537/boards/stamp.c
> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> @@ -1995,7 +1995,7 @@ static struct adp5588_gpio_platform_data adp5588_gpio_data = {
>   #endif
>   
>   #if IS_ENABLED(CONFIG_BACKLIGHT_ADP8870)
> -#include <linux/i2c/adp8870.h>
> +#include <linux/platform_data/adp8870.h>
>   static struct led_info adp8870_leds[] = {
>   	{
>   		.name = "adp8870-led7",
> diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c
> index 21acac90fd773f..058d1def2d1f4b 100644
> --- a/drivers/video/backlight/adp8870_bl.c
> +++ b/drivers/video/backlight/adp8870_bl.c
> @@ -18,7 +18,7 @@
>   #include <linux/workqueue.h>
>   #include <linux/slab.h>
>   
> -#include <linux/i2c/adp8870.h>
> +#include <linux/platform_data/adp8870.h>
>   #define ADP8870_EXT_FEATURES
>   #define ADP8870_USE_LEDS
>   
> diff --git a/include/linux/i2c/adp8870.h b/include/linux/platform_data/adp8870.h
> similarity index 100%
> rename from include/linux/i2c/adp8870.h
> rename to include/linux/platform_data/adp8870.h