Re: [PATCH v2 0/8] HID: Consolidate serializing ope/close in transport drivers

[Benjamin Tissoires]

On Jun 06 2017 or thereabouts, Dmitry Torokhov wrote:
> This originally came about as report of uhid sending duplicate open and
> premature close when hidraw was used alongside of input. After looking at
> the drivers I think we should consolidate user tracking inside of the HID
> core. While implementing this, there were a few cleanups as well.
> 
> V2:
> 
> - added greybus hid changes
> - added error handling in hiddev around hid_hw_open which is __much_check
> 

Looks good to me:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>

> Dmitry Torokhov (8):
>   HID: hiddev: use hid_hw_open/close instead of usbhid_open/close
>   HID: hiddev: use hid_hw_power instead of usbhid_get/put_power
>   HID: usbhid: do not rely on hid->open when deciding to do IO
>   HID: serialize hid_hw_open and hid_hw_close
>   HID: i2c-hid: remove custom locking from i2c_hid_open/close
>   HID: usbhid: remove custom locking from usbhid_open/close
>   greybus: hid: remove custom locking from gb_hid_open/close
>   HID: remove no longer used hid->open field
> 
>  drivers/hid/hid-core.c        |  89 +++++++++++++++++++++++++
>  drivers/hid/i2c-hid/i2c-hid.c |  32 +++------
>  drivers/hid/usbhid/hid-core.c | 150 ++++++++++++++++++++----------------------
>  drivers/hid/usbhid/hiddev.c   |  24 +++----
>  drivers/hid/usbhid/usbhid.h   |  15 +++--
>  drivers/staging/greybus/hid.c |  43 ++++--------
>  include/linux/hid.h           |  73 +++-----------------
>  7 files changed, 214 insertions(+), 212 deletions(-)
> 
> Thanks.
> 
> -- 
> Dmitry
>