Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

[Javier Martinez Canillas]

On Wed, Jun 7, 2017 at 4:10 PM, Javier Martinez Canillas
<javier@xxxxxxxxxxxx> wrote:

[snip]

>>
>> chip_id = (unsigned long)match->data;
>>
>
> ...but this particular driver only has a single entry in the OF table
> and so you can just do:
>
> tps->id = TPS65217;
>

In fact, it seems that the whole chip id logic can go away since no
one is using it. I see that the regulator driver checks for the chip
id value but I don't think that makes sense since the regulator
driver's probe function won't be called for other chips since they
won't match.

Best regards,
Javier