[PATCH] selftests: kselftest_harness: fix compile warnings
From: Shuah Khan
Date: Wed Jun 07 2017 - 13:57:41 EST
Fix the following compile warns. checkpatch wants trailing statements
on next line.
gcc -Wl,-no-as-needed -Wall -lpthread seccomp_bpf.c -o
/lkml/linux-kselftest/tools/testing/selftests/seccomp/seccomp_bpf
In file included from seccomp_bpf.c:40:0:
seccomp_bpf.c: In function âchange_syscallâ:
../kselftest_harness.h:558:2: warning: this âforâ clause does not
guard... [-Wmisleading-indentation]
for (; _metadata->trigger; _metadata->trigger = __bail(_assert))
^
../kselftest_harness.h:574:14: note: in expansion of macro
âOPTIONAL_HANDLERâ
} while (0); OPTIONAL_HANDLER(_assert)
^~~~~~~~~~~~~~~~
../kselftest_harness.h:440:2: note: in expansion of macro â__EXPECTâ
__EXPECT(expected, seen, ==, 0)
^~~~~~~~
seccomp_bpf.c:1313:2: note: in expansion of macro âEXPECT_EQâ
EXPECT_EQ(0, ret);
^~~~~~~~~
seccomp_bpf.c:1317:2: note: ...this statement, but the latter is
misleadingly indented as if it is guarded by the âforâ
{
^
make: Leaving directory
'/lkml/linux-kselftest/tools/testing/selftests/seccomp'
Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
---
tools/testing/selftests/kselftest_harness.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
index c56f72e07cd7..432245faeab3 100644
--- a/tools/testing/selftests/kselftest_harness.h
+++ b/tools/testing/selftests/kselftest_harness.h
@@ -555,7 +555,8 @@
* return while still providing an optional block to the API consumer.
*/
#define OPTIONAL_HANDLER(_assert) \
- for (; _metadata->trigger; _metadata->trigger = __bail(_assert))
+ for (; _metadata->trigger; _metadata->trigger = __bail(_assert)) \
+ ;
#define __EXPECT(_expected, _seen, _t, _assert) do { \
/* Avoid multiple evaluation of the cases */ \
--
2.11.0