Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages

From: Darwin Dingel
Date: Wed Jun 07 2017 - 17:59:40 EST


Hi Pavel,

Looks like uboot has similar IFC driver. Do you have plans to apply this change to uboot as well?


Cheers,
Darwin
â

From: Pavel Machek <pavel@xxxxxx>
Sent: Thursday, 1 June 2017 10:15 a.m.
To: Darwin Dingel
Cc: Boris Brezillon; richard@xxxxxx; dwmw2@xxxxxxxxxxxxx; computersforpeace@xxxxxxxxx; marek.vasut@xxxxxxxxx; cyrille.pitchen@xxxxxxxxx; linux-mtd@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; mark.marshall@xxxxxxxxxxxxxxxxx; b44839@xxxxxxxxxxxxx; prabhakar@xxxxxxxxxxxxx
Subject: Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages
Â
Hi!

> > You meen "errors = 0"? Does that actually make a difference? It is a
> > local variable, and continue makes sure the value is not used:
> >
>
> I missed the 'continue' statement there. In that case we don't need to
> reset 'error'.

Yes, thanks, I wanted to double-check. If you could take a look at
PATCHv2 -- it should have the problems fixed. Your Acked-by would be
nice ;-).

Thanks a lot,
ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html