Re: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection

[Richard Genoud]

2017-06-09 9:37 GMT+02:00 Linus Walleij <linus.walleij@xxxxxxxxxx>:
> On Thu, Jun 1, 2017 at 2:18 PM, Richard Genoud <richard.genoud@xxxxxxxxx> wrote:
>
>> The blink counter A was always selected because 0 was forced in the
>> blink select counter register.
>> The variable 'set' was obviously there to be used as the register value,
>> selecting the B counter when id==1 and A counter when id==0.
>>
>> Tested on clearfog-pro (Marvell 88F6828)
>>
>> Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support")
>> Reviewed-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>
>> Reviewed-by: Ralph Sennhauser <ralph.sennhauser@xxxxxxxxx>
>> Signed-off-by: Richard Genoud <richard.genoud@xxxxxxxxx>
>
> Patch applied for fixes.
>
> It appears this will clash with patches on the development branch :(
>
> I might screw up the merges so help me check the end result
> later.
Ok, no problem !

>
> Yours,
> Linus Walleij
Thanks !
Richard.