Re: [REGRESSION next] gpio-keys broken with commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register access")

[Gregory CLEMENT]

Hi Ralph,
 
 On ven., juin 09 2017, Ralph Sennhauser <ralph.sennhauser@xxxxxxxxx> wrote:

> Hi Thomas,
>
> Commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register
> access") in next-20170607 breaks gpio-keys on an armada-385 (Linksys
> WRT3200ACM), noticed due to missing /dev/input/event0 and the below
> dmesg output.
>
>   # dmesg -l 0,1,2,3
>   [    2.421130] genirq: Setting trigger mode 3 for irq 49 failed (mvebu_gpio_irq_set_type+0x0/0x168)
>   [    2.429953] gpio-keys gpio-keys: Unable to claim irq 49; error -22
>
>
> After reverting the offending commit all works again.

I found the bug and I've just sent a fix for it (use the v2 as the first
version was wrong).

Thanks for the report,

Gregory


>
> Ralph

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com