Re: [PATCH] i40evf: remove redundant null check on key
From: Dan Carpenter
Date: Sat Jun 10 2017 - 07:34:21 EST
This patch isn't right...
On Wed, Jun 07, 2017 at 12:54:07AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> key has previously been null checked so the subsequent null check
> is redundant as key can never be null at that point, so remove it.
>
Actually, it's the reverse. "key" is always NULL. Probably the ||
should be a &&?
regards,
dan carpenter