Re: [PATCH 1/2] perf evsel: Fix probing of precise_ip level for default cycles event

From: Ingo Molnar
Date: Wed Jun 14 2017 - 09:55:33 EST



* Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> Em Wed, Jun 14, 2017 at 12:51:55PM +0200, Ingo Molnar escreveu:
> >
> > * Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> >
> > > Can you try with the patch below, which is hackish but the minimal fix at this
> > > point. Later I'll come up with a way of returning a fully configured cycles
> > > evsel, which will make the tools code simpler, moving more stuff to the
> > > libraries.
> >
> > Yeah, this patch on top of your tree seems to work better now.
>
> So how do we proceed, do you want to keep these two as separate or can I
> squash them together, fix that problem with the unwind library and
> provide a new perf/urgent for you to use?
>
> Off to breakfast now tho :-)

Your call: I had to unpull, so feel free to rebase your urgent branch.

Thanks,

Ingo