Re: [PATCH] gpio: mvebu: change compatible string for PWM support

From: Linus Walleij
Date: Fri Jun 16 2017 - 05:13:53 EST


On Fri, Jun 9, 2017 at 9:45 AM, Richard Genoud <richard.genoud@xxxxxxxxx> wrote:
> 2017-06-09 9:42 GMT+02:00 Linus Walleij <linus.walleij@xxxxxxxxxx>:
>> On Thu, Jun 1, 2017 at 10:08 PM, Ralph Sennhauser
>> <ralph.sennhauser@xxxxxxxxx> wrote:
>>
>>> As it turns out more than just Armada 370 and XP support using GPIO
>>> lines as PWM lines. For example the Armada 38x family has the same
>>> hardware support. As such "marvell,armada-370-xp-gpio" for the
>>> compatible string is a misnomer.
>>>
>>> Change the compatible string to "marvell,armada-370-gpio" before the
>>> driver makes it out of the -rc stage. This also follows the practice of
>>> using only the first device family supported as part of the name.
>>>
>>> Also update the documentation and comments in the code accordingly.
>>>
>>> Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support")
>>> Signed-off-by: Ralph Sennhauser <ralph.sennhauser@xxxxxxxxx>
>>
>> Patch applied for next with the tags.
> You mean for fixes right ?
> The goal was to correct "marvell,armada-370-xp-gpio" before 4.12 is out.

OK I moved it to fixes.

Yours,
Linus Walleij