Re: [PATCH] serial: Delete dead code for CIR serial ports

[Andy Shevchenko]

On Thu, 2017-06-15 at 17:54 +0200, Matthias Brugger wrote:
> Commit e4fda3a04275 ("serial: don't register CIR serial ports") adds a
> check for PORT_8250_CIR to serial8250_register_8250_port(). But the
> code
> isn't needed as the function never takes the branch when the port is
> CIR
> serial port.

> +		if (serial8250_isa_config != NULL)

> +			serial8250_isa_config(0, &uart->port,
> +					&uart->capabilities);

Can't it be one line after all?

> Â

> +		ret = uart_add_one_port(&serial8250_reg,
> +					&uart->port);

Ditto.

> +		if (ret == 0)
> +			ret = uart->port.line;

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy