Re: [PATCH 08/27] VFS: Introduce the structs and doc for a filesystem context [ver #5]
From: Randy Dunlap
Date: Sat Jun 17 2017 - 11:12:00 EST
On 06/17/2017 07:56 AM, Jeff Layton wrote:
> On Sat, 2017-06-17 at 15:18 +0100, David Howells wrote:
>> Theodore Ts'o <tytso@xxxxxxx> wrote:
>>> I don't know that this is a hard and fast rule. Struct bio uses a
>>> "bi_" prefix (e.g., bi_error, bi_opf, bi_iter, etc.).
>> Linus told me to stop doing it.
> That's a pity... I tend to like little prefixes on fields too. Trying to
> find all occurrences of a symbol called "flags" in cscope is a losing
> Do you have a reference to the discussion so I can understand the
> rationale there?
Ack. This doesn't seem helpful.
He also objected to drivers with file names that begin with the parent
directory name, but we still have hundreds of those (see clk/, extcon/,
gpio/, hid/, i2c/, leds/ [then I stopped looking]).