Re: [PATCH RESEND] i2c: add sc18is600 driver

[Andy Shevchenko]

On Sun, Jun 18, 2017 at 5:02 PM, Sebastian Reichel <sre@xxxxxxxxxx> wrote:

> Thanks for your feedback.

You're welcome!

> On Sat, Jun 17, 2017 at 09:13:32PM +0300, Andy Shevchenko wrote:
>> On Tue, Jun 13, 2017 at 6:47 PM, Sebastian Reichel <sre@xxxxxxxxxx> wrote:

>> > +       snprintf(dev->adapter.name, sizeof(dev->adapter.name),
>>
>> > +                "SC18IS600 at SPI %02d device %02d",
>>
>> Isn't too much for adapter name?
>> I don't remember if it's part of ABI, in that case it's even worse.
>
> Well, it's displayed by "i2cdetect -l". Here are the names from some
> other drivers, which I used as reference:
>
> i2c-tiny-usb at bus %03d device %03d
> i2c-diolan-u2c at bus %03d device %03d
> OSIF at bus %03d device %03d
> SMBus Via Pro adapter at %04x
> SMBus SIS5595 adapter at %04x

Ah, okay.

-- 
With Best Regards,
Andy Shevchenko