Re: [RFC v2 12/12]selftest: Updated protection key selftest
From: Michael Ellerman
Date: Mon Jun 19 2017 - 07:05:01 EST
Ram Pai <linuxram@xxxxxxxxxx> writes:
> Added test support for PowerPC implementation off protection keys.
>
> Signed-off-by: Ram Pai <linuxram@xxxxxxxxxx>
> ---
> tools/testing/selftests/vm/Makefile | 1 +
> tools/testing/selftests/vm/pkey-helpers.h | 365 +++++++
> tools/testing/selftests/vm/protection_keys.c | 1451 +++++++++++++++++++++++++
> tools/testing/selftests/x86/Makefile | 2 +-
> tools/testing/selftests/x86/pkey-helpers.h | 219 ----
> tools/testing/selftests/x86/protection_keys.c | 1395 ------------------------
Please split the move and the addition of the powerpc code into two
separate patches (move first). That way we can actually see what you're
doing to add powerpc support.
cheers