Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions
From: Wolfram Sang
Date: Mon Jun 19 2017 - 11:59:08 EST
Hiya,
> Believe me I've looked for mistakes like this but I've read the code so many
> times I don't think I can see the obvious anymore.
Yes, I know this. And you worked hard on this slave feature,
acknowledged.
Patches 1-4 look good to me from what I glimpsed. I largely trust here
the *much* appreciated review from Jarkko and Andy. Thanks a lot, guys!
I wonder if we haven't reached a state where Luis just could fix the
buildbot error (missing 'select I2C_SLAVE') and the thing pointed out by
Andy and we handle further small fixes incrementally during the v4.13
cycle? AFAICS there is no major show-stopper, or am I wrong?
Thanks guys,
Wolfram
Attachment:
signature.asc
Description: PGP signature