Re: [PATCH] [perf/core branch] perf coresight: Fix ARM builds caused by misplaced __printf

From: Arnaldo Carvalho de Melo
Date: Mon Jun 19 2017 - 14:42:24 EST


Em Mon, Jun 19, 2017 at 11:51:20AM -0600, Mathieu Poirier escreveu:
> On 16 June 2017 at 13:59, Kim Phillips <kim.phillips@xxxxxxx> wrote:
> > -static int cs_device__print_file(const char *name, const char *fmt, ...) __printf(2, 3)
> > +static int __printf(2, 3) cs_device__print_file(const char *name, const char *fmt, ...)
> > {
> > va_list args;
> > FILE *file;
>
> I just tested Kim's solution on my side.
>
> Acked-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>

Thanks for checking, since I haven't pushed this to Ingo I just squashed
Kim's fix into the buggy cset.

Now I'm trying to build it with lots of cross build containers to see if
there are any other problems before push this up to Ingo.

- Arnaldo