Re: [PATCH][next] ASoC: rsnd: make main_rate signed to check for -ve error return codes

[Kuninori Morimoto]

Hi Colin

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> The comparison of main_rate < 0 has no effect because main_rate is
> an unsigned int. Make it signed so that any -ve error returns from the
> call to rsnd_clk_query can be detected.
> 
> Detected by CoverityScan, CID#1446152 ("Unsigned compared against 0")
> 
> Fixes: ef4cf5d6a143e0 ("ASoC: rsnd: add rsnd_ssi_clk_query()")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---

Thank you for your patch.
But, I posted this fixup patch (not yet accepted)

To: Mark Brown <broonie@xxxxxxxxxx>, Julia Lawall <julia.lawall@xxxxxxx>
Subject: [PATCH] ASoC: rsnd: fixup unsigned expression compared with zero: main_rate
From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
CC: Linux-ALSA <alsa-devel@xxxxxxxxxxxxxxxx>, Simon <horms@xxxxxxxxxxxx>,
 <linux-renesas-soc@xxxxxxxxxxxxxxx>
Date: Fri, 16 Jun 2017 00:02:59 +0000

>  sound/soc/sh/rcar/ssi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c
> index c8956c3484dd..d220512918f9 100644
> --- a/sound/soc/sh/rcar/ssi.c
> +++ b/sound/soc/sh/rcar/ssi.c
> @@ -258,7 +258,7 @@ static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod,
>  	struct rsnd_mod *ssi_parent_mod = rsnd_io_to_mod_ssip(io);
>  	int chan = rsnd_runtime_channel_for_ssi(io);
>  	int idx, ret;
> -	unsigned int main_rate;
> +	int main_rate;
>  	unsigned int rate = rsnd_io_is_play(io) ?
>  		rsnd_src_get_out_rate(priv, io) :
>  		rsnd_src_get_in_rate(priv, io);
> -- 
> 2.11.0
>