Re: [PATCH v2] drm/exynos/dsi: Remove error handling for bridge_node DT parsing

[Hoegeun Kwon]

Hello Tobias,

Sorry for late reply.

On 06/14/2017 09:30 PM, Tobias Jakobi wrote:
> Hello Hoegeun,
>
> my last question (does this regress the case "node required, but
> absent") still stands.
>
>
> Hoegeun Kwon wrote:
> > Remove the error handling of bridge_node because the bridge_node is
> > required optionally.
> I don't think a construction like that exists. Either it's required, or
> it's optional. "required optionally" makes no sense to me (but I'm not a
> native speaker).
>
> - Tobias

The bridge_node is optional.
I will change commit message and send ver3 patch.

Best regards,
Hoegeun

> > For example, In case of Exynos SoC, a bridge device such as mDNIe and
> > MIC could be placed between Display Controller and MIPI DSI device but
> > the bridge device is required optionally.
> >
> > Signed-off-by: Hoegeun Kwon <hoegeun.kwon@xxxxxxxxxxx>
> > ---
> >
> > Hi Inki and Tobias,
> >
> > Thanks for your review.
> >
> > Changes for V2:
> > - Modified the commit message in more detail than before.
> >
> > Best Regards,
> > Hoegeun
> >
> >   drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 --
> >   1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> > index a11b795..6ee0dac 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> > @@ -1651,8 +1651,6 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
> >   		return ret;
> >   
> >   	dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
> > -	if (!dsi->bridge_node)
> > -		return -EINVAL;
> >   
> >   	return 0;
> >   }