Re: [PATCH v4 6/6] arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K

From: Thomas Petazzoni
Date: Tue Jun 20 2017 - 11:37:09 EST


On Tue, 20 Jun 2017 16:56:35 +0200, Gregory CLEMENT wrote:

> > +#include <dt-bindings/interrupt-controller/mvebu-icu.h>
> With this line you created a dependency with the patch "irqchip:
> irq-mvebu-icu: new driver for Marvell ICU". And without it the dtb is
> not buidable.
> So either I wait for the next kernel release to apply it or I will need
> a stable branch with the commit adding the mvebu-icu.h file.

Alternatively, I could change the patch to use hardcoded values for now
(i.e replace ICU_GRP_NSR everywhere by 0x0), and then change it during
the next kernel cycle to use the #define value. I would really prefer
such a solution to a solution where merging the entire ICU DT change
would be delayed by one cycle.

Let me know what you prefer. Maybe Marc can say if the irqchip
maintainers can provide a stable branch containing the mvebu-icu.h file.

Best regards,

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering