Re: [PATCH v7 06/36] x86/mm: Add Secure Memory Encryption (SME) support

[Tom Lendacky]

On 6/20/2017 3:49 PM, Thomas Gleixner wrote:
> On Fri, 16 Jun 2017, Tom Lendacky wrote:
> >   
> > +config ARCH_HAS_MEM_ENCRYPT
> > +	def_bool y
> > +	depends on X86
>
> That one is silly. The config switch is in the x86 KConfig file, so X86 is
> on. If you intended to move this to some generic place outside of
> x86/Kconfig then this should be
>
> config ARCH_HAS_MEM_ENCRYPT
> 	bool
>
> and x86/Kconfig should have
>
>      	select ARCH_HAS_MEM_ENCRYPT
>
> and that should be selected by AMD_MEM_ENCRYPT

This is used for deciding whether to include the asm/mem_encrypt.h file
so it needs to be on whether AMD_MEM_ENCRYPT is configured or not. I'll
leave it in the x86/Kconfig file and remove the depends on line.

Thanks,
Tom

> > +config AMD_MEM_ENCRYPT
> > +	bool "AMD Secure Memory Encryption (SME) support"
> > +	depends on X86_64 && CPU_SUP_AMD
> > +	---help---
> > +	  Say yes to enable support for the encryption of system memory.
> > +	  This requires an AMD processor that supports Secure Memory
> > +	  Encryption (SME).
>
> Thanks,
>
> 	tglx