Re: [PATCH v5 0/6] Add support for the ICU unit in Marvell Armada 7K/8K

From: Marc Zyngier
Date: Wed Jun 21 2017 - 11:14:36 EST


On 21/06/17 14:29, Thomas Petazzoni wrote:
> Hello,
>
> The Marvell Armada 7K/8K SoCs are composed of two parts: the AP (which
> contains the CPU cores) and the CP (which contains most
> peripherals). The 7K SoCs have one CP, while the 8K SoCs have two CPs,
> doubling the number of available peripherals.
>
> In terms of interrupt handling, all devices in the CPs are connected
> through wired interrupt to a unit called ICU located in each CP. This
> unit converts the wired interrupts from the devices into memory
> transactions.
>
> Inside the AP, there is a GIC extension called GICP, which allows a
> memory write transaction to trigger a GIC SPI interrupt. The ICUs in
> each CP are therefore configured to trigger a memory write into the
> appropriate GICP register so that a wired interrupt from a CP device
> is converted into a memory write, itself converted into a regular GIC
> SPI interrupt.
>
> Until now, the configuration of the ICU was done statically by the
> firmware, and therefore the Device Tree files in Linux were specifying
> directly GIC interrupts for the interrupts of CP devices. However,
> with the growing number of devices in the CP, a static allocation
> scheme doesn't work for the long term.
>
> This patch series therefore makes Linux aware of the ICU: GIC SPI
> interrupts are dynamically allocated, and the ICU is configured
> accordingly to route a CP wired interrupt to the allocated GIC SPI
> interrupt.
>
> In detail:

[...]

> Thomas Petazzoni (6):
> dt-bindings: interrupt-controller: add DT binding for the Marvell GICP
> dt-bindings: interrupt-controller: add DT binding for the Marvell ICU
> irqchip: irq-mvebu-gicp: new driver for Marvell GICP
> irqchip: irq-mvebu-icu: new driver for Marvell ICU
> arm64: marvell: enable ICU and GICP drivers
> arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K
>
> .../bindings/interrupt-controller/marvell,gicp.txt | 27 ++
> .../bindings/interrupt-controller/marvell,icu.txt | 51 ++++
> arch/arm64/Kconfig.platforms | 2 +
> arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 7 +
> .../boot/dts/marvell/armada-cp110-master.dtsi | 59 +++--
> .../arm64/boot/dts/marvell/armada-cp110-slave.dtsi | 55 ++--
> drivers/irqchip/Kconfig | 6 +
> drivers/irqchip/Makefile | 2 +
> drivers/irqchip/irq-mvebu-gicp.c | 279 ++++++++++++++++++++
> drivers/irqchip/irq-mvebu-gicp.h | 12 +
> drivers/irqchip/irq-mvebu-icu.c | 289 +++++++++++++++++++++
> .../dt-bindings/interrupt-controller/mvebu-icu.h | 15 ++
> 12 files changed, 756 insertions(+), 48 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/marvell,gicp.txt
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/marvell,icu.txt
> create mode 100644 drivers/irqchip/irq-mvebu-gicp.c
> create mode 100644 drivers/irqchip/irq-mvebu-gicp.h
> create mode 100644 drivers/irqchip/irq-mvebu-icu.c
> create mode 100644 include/dt-bindings/interrupt-controller/mvebu-icu.h
>

It all looks good to me. How do we merge this? I take the first five
patches and Gregory takes the last one?

Thanks,

M.
--
Jazz is not dead. It just smells funny...