Re: [PATCH 0/5] rtlwifi: Neatening

[Larry Finger]

On 06/19/2017 03:18 PM, Joe Perches wrote:
> Joe Perches (5):
>    rtlwifi: Use temporary ops variable to reduce code size
>    rtlwifi: Use temporary variable btc_ops for rtlpriv->btcoexist.btc_ops
>    rtlwifi: Add and use convenience macro rtl_btc
>    realtek: btcoexist: Make the rtl_btc_ops struct const
>    realtek: rtlwifi: drivers: Use the rtl_btc convenience macro
>
>   drivers/net/wireless/realtek/rtlwifi/base.c        |  46 ++--
>   .../wireless/realtek/rtlwifi/btcoexist/rtl_btc.c   |   4 +-
>   .../wireless/realtek/rtlwifi/btcoexist/rtl_btc.h   |   2 +-
>   drivers/net/wireless/realtek/rtlwifi/core.c        | 189 ++++++++--------
>   drivers/net/wireless/realtek/rtlwifi/efuse.c       |   9 +-
>   drivers/net/wireless/realtek/rtlwifi/pci.c         | 242 +++++++++++----------
>   drivers/net/wireless/realtek/rtlwifi/ps.c          |  83 +++----
>   .../net/wireless/realtek/rtlwifi/rtl8192ee/hw.c    |   3 +-
>   .../wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c   |   4 +-
>   .../net/wireless/realtek/rtlwifi/rtl8723ae/hw.c    |   3 +-
>   .../net/wireless/realtek/rtlwifi/rtl8723be/hw.c    |   3 +-
>   .../net/wireless/realtek/rtlwifi/rtl8821ae/fw.c    |   6 +-
>   .../net/wireless/realtek/rtlwifi/rtl8821ae/hw.c    |   3 +-
>   drivers/net/wireless/realtek/rtlwifi/usb.c         |  40 ++--
>   drivers/net/wireless/realtek/rtlwifi/wifi.h        |   9 +-
>   15 files changed, 336 insertions(+), 310 deletions(-)

Joe,

In general, I approve of your patches. Unfortunately, they will conflict with a 
number of changes that I am currently making. If you would like, I can merge 
your patches, fix the conflicts, and submit a version 2 for you.

Larry