Re: [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi devices

[jeffy]

Hi Krzysztof,

thanx for noting that, will add it to next version :)


On 06/21/2017 11:36 PM, Krzysztof Kozlowski wrote:
> On Wed, Jun 21, 2017 at 11:33:29PM +0800, jeffy wrote:
> > Hi Krzysztof,
> >
> > thanx for your comment.
> >
> > On 06/21/2017 06:45 PM, Krzysztof Kozlowski wrote:
> > > On Wed, Jun 21, 2017 at 12:01 PM, Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx> wrote:
> > > > We used to enable wakeup for cros-ec-spi devices unconditionally.
> > > > Now we are using the more generic wakeup-source property to enable it.
> > >
> > > Using wakeup-source property is still enabling this unconditionally.
> > > What  do you exactly mean here?
> > i mean the wakeup-source is an optional property, we can disable wakeup by
> > not adding it.
>
> Maybe mention this in commit msg? This removes any confusion. "Till now
> the driver always enabled wakeup but now it supports wakeup property so
> add it to keep same functionality."
>
> Best regards,
> Krzysztof