Re: [PATCH v5 0/2] drm: atmel-hlcdc: clut support
From: Nicolas Ferre
Date: Thu Jun 22 2017 - 04:12:20 EST
On 22/06/2017 at 07:03, Peter Rosin wrote:
> This series adds support for an 8-bit clut mode in the atmel-hlcdc
> Changes since v4:
> - Added .clut_offset for overlay2 at 0xe00 for sama5d4 (unconfirmed if 0xe00
> is the correct offset, but I'll eat my hat if it's not there).
You hat is safe and so you are: I confirm that overlay2 clut is at 0xe00
based on an older datasheet.
> The sama5d4
> overlay2 is indeed there, it is just AWOL in the current datasheet.
> - Added Acked-by from Daniel on patch 2/2.
> Changes since v3:
> - Dropped ugly code (patches 2/3 and 3/3) for legacy fbdev interaction.
> - Slit out the .set_property change to a patch of its own.
> Changes since v2:
> - Fix mapping to the clut registers.
> Changes since v1:
> - Move the clut update from atmel_hlcdc_crtc_mode_valid to
> - Add default .gamma_set helper (drm_atomic_helper_legacy_gamma_set).
> - Don't keep a spare copy of the clut, reuse gamma_store instead.
> - Don't try to synchronize the legacy fb clut with the drm clut.
> Peter Rosin (2):
> drm: atmel-hlcdc: add missing .set_property helper to the crtc
> drm: atmel-hlcdc: add support for 8-bit color lookup table mode
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 5 +++++
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 14 ++++++++++++
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 16 ++++++++++++++
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 29 +++++++++++++++++++++++++
> 4 files changed, 64 insertions(+)