Re: [PATCH 2/2] ARM: cpuidle: Support asymmetric idle definition
From: Rafael J. Wysocki
Date: Thu Jun 22 2017 - 10:35:16 EST
On Thursday, June 22, 2017 02:25:19 PM Daniel Lezcano wrote:
> On 12/06/2017 20:49, Rafael J. Wysocki wrote:
> > On Monday, June 12, 2017 05:55:10 PM Daniel Lezcano wrote:
> >> Some hardware have clusters with different idle states. The current code does
> >> not support this and fails as it expects all the idle states to be identical.
> >> Because of this, the Mediatek mtk8173 had to create the same idle state for a
> >> big.Little system and now the Hisilicon 960 is facing the same situation.
> >> Solve this by simply assuming the multiple driver will be needed for all the
> >> platforms using the ARM generic cpuidle driver which makes sense because of the
> >> different topologies we can support with a single kernel for ARM32 or ARM64.
> >> Every CPU has its own driver, so every single CPU can specify in the DT the
> >> idle states.
> >> This simple approach allows to support the future dynamIQ system, current SMP
> >> and HMP.
> >> Tested on:
> >> - 96boards: Hikey 620
> >> - 96boards: Hikey 960
> >> - 96boards: dragonboard410c
> >> - Mediatek 8173
> >> Cc: Sudeep Holla <sudeep.holla@xxxxxxx>
> >> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> >> Tested-by: Leo Yan <leo.yan@xxxxxxxxxx>
> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> > There seems to have been quite some discussion regarding this one and I'm not
> > sure about the resolution of it.
> > I'd feel more comfortable with an ACK or Reviewed-by from Sudeep or Lorenzo here.
> Hi Rafael,
> just a gentle reminder, Sudeep acked the patch.
Yes, I'll get to it later today, most likely.