Re: [PATCH v9 0/3] Cavium ThunderX2 SMMUv3 errata workarounds

From: Will Deacon
Date: Thu Jun 22 2017 - 14:58:15 EST


On Thu, Jun 22, 2017 at 07:22:57PM +0100, Will Deacon wrote:
> On Thu, Jun 22, 2017 at 05:35:35PM +0530, Geetha sowjanya wrote:
> > Cavium ThunderX2 SMMUv3 implementation has two Silicon Erratas.
> > 1. Errata ID #74
> > SMMU register alias Page 1 is not implemented
> > 2. Errata ID #126
> > SMMU doesnt support unique IRQ lines and also MSI for gerror,
> > eventq and cmdq-sync
> >
> > The following patchset does software workaround for these two erratas.
>
> I've picked up the first two patches, and left comments on the final patch.

... except that it doesn't build:


drivers/acpi/arm64/iort.c: In function âarm_smmu_v3_resource_sizeâ:
drivers/acpi/arm64/iort.c:837:21: error: âACPI_IORT_SMMU_V3_CAVIUM_CN99XXâ undeclared (first use in this function)
if (smmu->model == ACPI_IORT_SMMU_V3_CAVIUM_CN99XX)
^
drivers/acpi/arm64/iort.c:837:21: note: each undeclared identifier is reported only once for each function it appears in
make[4]: *** [drivers/acpi/arm64/iort.o] Error 1


I don't see ACPI_IORT_SMMU_V3_CAVIUM_CN99XX defined, even in linux-next.

What's the plan here?

Will