Re: [PATCH] EDAC, pnd2_edac: make function sbi_send static
From: Luck, Tony
Date: Fri Jun 23 2017 - 16:48:05 EST
On Fri, Jun 23, 2017 at 10:58:24AM +0200, Borislav Petkov wrote:
> On Fri, Jun 23, 2017 at 09:48:55AM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> > -int sbi_send(int port, int off, int op, u32 *data)
> > +static int sbi_send(int port, int off, int op, u32 *data)
> Tony, were those supposed to be used somewhere outside of the driver,
> i.e., that CONFIG_X86_INTEL_SBI_APL thing?
No. This function is internal and can be static.
The CONFIG_X86_INTEL_SBI_APL thing is about sbi_apl_commit()
while is still waiting for a sideband driver that defines it
to be pushed upstream.