Re: [PATCH] rtc: opal: Implement rtc_class_ops.alarm_irq_enable callback

From: Alexandre Belloni
Date: Sat Jun 24 2017 - 01:49:16 EST


On 31/05/2017 at 18:39:01 +0530, Vaibhav Jain wrote:
> Provide an implementation of the callback
> rtc_class_ops.alarm_irq_enable for rtc-opal driver. This callback is
> called when the wake alarm is disabled via the command:
>
> 'echo 0 > /sys/class/rtc/rtc0/wakealarm'
>
> Without this the Timed-Power-On(TPO) config remains set even when its
> disabled by the above command and FSP will still force machine
> boot at previously configured alarm time.
>
> The callback is implemented as function opal_tpo_alarm_irq_enable()
> which calls opal_set_tpo_time() with alarm.enabled == 0. A branch is
> added to opal_set_tpo_time() to handle this case by passing y_m_d ==
> h_m_s_ms == 0 to opal as arguments for opal_tpo_write() call.
>
> Signed-off-by: Vaibhav Jain <vaibhav@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/rtc/rtc-opal.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
Applied, thanks.

--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com