Re: [PATCH] scsi: hisi_sas: redefine hisi_sas_phy.phy_type as u32

From: Martin K. Petersen
Date: Mon Jun 26 2017 - 13:41:58 EST



John,

> Element phy_type is a bitmask and it only ever has 2 bits possibly
> set, and it is overkill to define as a u64, so redefine as a u32.
>
> This change resolves static code check complaint that "phy->phy_type
> &= ~PORT_TYPE_SAS;" would unintentionally clear the high 32 bits as
> well.
>
> Structure hisi_sas_phy is also reordered to ensure packing efficiency.

Applied to 4.13/scsi-queue, thanks!

--
Martin K. Petersen Oracle Linux Engineering