Re: [PATCH] tracing/kprobes: allow to create probe with a module name starting with a digit
From: Steven Rostedt
Date: Tue Jun 27 2017 - 10:07:55 EST
On Tue, 27 Jun 2017 17:38:30 +0900
Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> On Thu, 22 Jun 2017 11:24:42 +0200
> Sabrina Dubroca <sd@xxxxxxxxxxxxxxx> wrote:
>
> > Always try to parse an address, since kstrtoul() will safely fail when
> > given a symbol as input. If that fails (which will be the case for a
> > symbol), try to parse a symbol instead.
> >
> > This allows creating a probe such as:
> >
> > p:probe/vlan_gro_receive 8021q:vlan_gro_receive+0
> >
> > Which is necessary for this command to work:
> >
> > perf probe -m 8021q -a vlan_gro_receive
> >
>
> Ah, I forgot that case.
> Nice catch!
>
> Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
>
Thanks Masami,
I can take this. Should this go to stable?
-- Steve