RE: [v3] drivers:soc:fsl:qbman:qman.c: Sleep instead of stuck hacking jiffies.

From: Leo Li
Date: Tue Jun 27 2017 - 12:38:19 EST




> -----Original Message-----
> From: Scott Wood [mailto:oss@xxxxxxxxxxxx]
> Sent: Saturday, June 24, 2017 9:47 PM
> To: Karim Eshapa <karim.eshapa@xxxxxxxxx>
> Cc: Roy Pledge <roy.pledge@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> Claudiu Manoil <claudiu.manoil@xxxxxxx>; colin.king@xxxxxxxxxxxxx;
> linuxppc-dev@xxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Leo Li
> <leoyang.li@xxxxxxx>
> Subject: Re: [v3] drivers:soc:fsl:qbman:qman.c: Sleep instead of stuck
> hacking jiffies.
>
> On Fri, May 05, 2017 at 07:45:18AM +0200, Karim Eshapa wrote:
> > Use msleep() instead of stucking with
> > long delay will be more efficient.
> >
> > Signed-off-by: Karim Eshapa <karim.eshapa@xxxxxxxxx>
> > ---
> > drivers/soc/fsl/qbman/qman.c | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
>
> Acked-by: Scott Wood <oss@xxxxxxxxxxxx>
>
> (though the subject line should be "soc/qman: ...")
>
> Leo, are you going to send this patch (and other qman patches) via arm-soc?

Yes. I can take it through the pull request for soc/fsl via arm-soc. As mentioned in the feedback from David in another email, probably we should update the comment and commit message to mention how 10000 cycles becomes 1ms.

Regards,
Leo