RE: [PATCH] staging: unisys: visorbus: constify visorchipset_parahotplug_group

From: Kershner, David A
Date: Tue Jun 27 2017 - 13:06:13 EST


> -----Original Message-----
> From: devel [mailto:driverdev-devel-bounces@xxxxxxxxxxxxxxxxxxxxxx] On
> Behalf Of Arvind Yadav
> Sent: Friday, June 23, 2017 2:31 AM
> To: gregkh@xxxxxxxxxxxxxxxxxxx; Sell, Timothy C
> <Timothy.Sell@xxxxxxxxxx>; Wadgaonkar, Sameer Laxmikant
> <Sameer.Wadgaonkar@xxxxxxxxxx>; jon.frisch@xxxxxxxxxx
> Cc: devel@xxxxxxxxxxxxxxxxxxxx; *S-Par-Maintainer
> <SParMaintainer@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] staging: unisys: visorbus: constify
> visorchipset_parahotplug_group
>
> File size before:
> text data bss dec hex filename
> 11058 816 24 11898 2e7a
> drivers/staging/unisys/visorbus/visorchipset.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 11122 752 24 11898 2e7a
> drivers/staging/unisys/visorbus/visorchipset.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
Acked-by: David Kershner <david.kershner@xxxxxxxxxx>

> ---
> drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
> b/drivers/staging/unisys/visorbus/visorchipset.c
> index 4cfd0fa..5a499fa 100644
> --- a/drivers/staging/unisys/visorbus/visorchipset.c
> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> @@ -1151,7 +1151,7 @@ static ssize_t deviceenabled_store(struct device
> *dev,
> NULL
> };
>
> -static struct attribute_group visorchipset_parahotplug_group = {
> +static const struct attribute_group visorchipset_parahotplug_group = {
> .name = "parahotplug",
> .attrs = visorchipset_parahotplug_attrs
> };
> --
> 1.9.1
>
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel