Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

[Jeff Kirsher]

On Wed, 2017-06-28 at 05:28 +1000, Dave Airlie wrote:
> On 20 June 2017 at 18:49, Daniel Vetter <daniel@xxxxxxxx> wrote:
> > On Wed, Jun 07, 2017 at 01:07:33AM +0000, Brown, Aaron F wrote:
> > > > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@xxxxxxxxxx]
> > > > On Behalf
> > > > Of Jeff Kirsher
> > > > Sent: Tuesday, June 6, 2017 1:46 PM
> > > > To: David Miller <davem@xxxxxxxxxxxxx>; Nikula, Jani
> > > > <jani.nikula@xxxxxxxxx>
> > > > Cc: Ursulin, Tvrtko <tvrtko.ursulin@xxxxxxxxx>; daniel.vetter@ffwll
> > > > .ch; intel-
> > > > gfx@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > > > jani.nikula@xxxxxxxxxxxxxxx; chris@xxxxxxxxxxxxxxxxxx; Ertman,
> > > > David M
> > > > <david.m.ertman@xxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx; dri-
> > > > devel@xxxxxxxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; airlied@gmail.
> > > > com
> > > > Subject: Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo
> > > > e1000e_pm_freeze if __e1000_shutdown fails
> > > > 
> > > > On Fri, 2017-06-02 at 14:14 -0400, David Miller wrote:
> > > > > From: Jani Nikula <jani.nikula@xxxxxxxxx>
> > > > > Date: Wed, 31 May 2017 18:50:43 +0300
> > > > > 
> > > > > > From: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > > > > > 
> > > > > > An error during suspend (e100e_pm_suspend),
> > > > > 
> > > > > Â...
> > > > > > lead to complete failure:
> > > > > 
> > > > > Â...
> > > > > > The unwind failures stems from commit 2800209994f8 ("e1000e:
> > > > > > Refactor PM
> > > > > > flows"), but it may be a later patch that introduced the non-
> > > > > > recoverable
> > > > > > behaviour.
> > > > > > 
> > > > > > Fixes: 2800209994f8 ("e1000e: Refactor PM flows")
> > > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847
> > > > > > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> > > > > > Cc: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
> > > > > > Cc: Dave Ertman <davidx.m.ertman@xxxxxxxxx>
> > > > > > Cc: Bruce Allan <bruce.w.allan@xxxxxxxxx>
> > > > > > Cc: intel-wired-lan@xxxxxxxxxxxxxxxx
> > > > > > Cc: netdev@xxxxxxxxxxxxxxx
> > > > > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > > > > > [Jani: bikeshed repainted]
> > > > > > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> > > > > 
> > > > > Jeff, please make sure this gets submitted to me soon.
> > > > 
> > > > Expect it later tonight, just finishing up testing.
> > > 
> > > Tested-by: Aaron Brown <aaron.f.brown@xxxxxxxxx>
> > 
> > Hm, I seem to be blind, but I can't find it anywhere in -rc6. Does
> > someone
> > have the sha1 from Linus' git for this patch?
> 
> Guys this is a pretty serious regression, just left blowing in the
> wind, is anyone responsible for e1000e?

This was submitted and accepted into David Miller's net-next tree.  I can
see if Dave can pull it into his net tree.  DOes stable need to pick this
up as well?

Attachment: signature.asc
Description: This is a digitally signed message part