Re: [PATCH/RFC 2/4] perf annotate: Add new source code view to the annotate TUI browser

From: Milian Wolff
Date: Wed Jun 28 2017 - 05:44:59 EST


On Wednesday, June 28, 2017 5:14:12 AM CEST Taeung Song wrote:
> Unlike asm code level, the new source code view
> provides a additional viewpoint based on source code level
> for performance analysis.
>
> Of course, current disassembly view can show itself with pieces of source
> code but some users want to check the result of performance analysis
> based on full source code view. So add this view to the annotate TUI
> browser.
>
> Users can switch to the new source code view by a 'S' key
> and additionally support a 't' key toggling total period view.

The 't' key support should be a separate patch, I guess. It also does not
update the column header (it stays at "Percent").

--
Milian Wolff | milian.wolff@xxxxxxxx | Senior Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

Attachment: smime.p7s
Description: S/MIME cryptographic signature