Re: [PATCH 2/3] iommu/iova: don't disable preempt around this_cpu_ptr()
From: Joerg Roedel
Date: Wed Jun 28 2017 - 06:26:47 EST
On Wed, Jun 28, 2017 at 11:31:55AM +0200, Sebastian Andrzej Siewior wrote:
> It really does. The spin_lock() does disable preemption but this is not
> the problem. The thing is that the preempt_disable() is superfluous and
> it hurts Preempt-RT (and this is how I noticed it). Also the
> get_cpu_ptr() is not requited and was only added to keep lockdep quiet
> (according to the history).
> Everything else here can stay as-is, I am just asking for the removal of
> the redundant preempt_disable() where it is not required.
Okay, makes sense, I applied both patches.
Thanks,
Joerg