Re: [PATCH NET V7 1/2] net: phy: Add phy loopback support in net phy framework

From: Yunsheng Lin
Date: Wed Jun 28 2017 - 21:36:20 EST


Hi, Andrew

On 2017/6/28 21:27, Andrew Lunn wrote:
> On Wed, Jun 28, 2017 at 05:13:10PM +0800, Lin Yun Sheng wrote:
>> This patch add set_loopback in phy_driver, which is used by MAC
>> driver to enable or disable phy loopback. it also add a generic
>> genphy_loopback function, which use BMCR loopback bit to enable
>> or disable loopback.
>>
>> Signed-off-by: Lin Yun Sheng <linyunsheng@xxxxxxxxxx>
>
> Hi Lin
>
> It is normal to include my
>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
>
> when resubmitting a patch. The only time you drop such tags is when
> you make a big change.
Will do next time, thanks for reviewing.

Best Regards
Yunsheng Lin