Re: [PATCH] thermal/intel_powerclamp: add const to thermal_cooling_device_ops structure

[Zhang Rui]

On Wed, 2017-06-21 at 12:39 +0530, Bhumika Goyal wrote:
> Declare thermal_cooling_device_ops structure as const as it is only
> passed
> as an argument to the function thermal_cooling_device_register and
> this
> argument is of type const. So, declare the structure as const.
> 
I checked the source and the code is written in this way as well in
some other drivers, why not fix them altogether?

thanks,
rui
> Signed-off-by: Bhumika Goyal <bhumirks@xxxxxxxxx>
> ---
> Âdrivers/thermal/intel_powerclamp.c | 2 +-
> Â1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/intel_powerclamp.c
> b/drivers/thermal/intel_powerclamp.c
> index d718cd1..e4c68b7 100644
> --- a/drivers/thermal/intel_powerclamp.c
> +++ b/drivers/thermal/intel_powerclamp.c
> @@ -659,7 +659,7 @@ static int powerclamp_set_cur_state(struct
> thermal_cooling_device *cdev,
> Â}
> Â
> Â/* bind to generic thermal layer as cooling device*/
> -static struct thermal_cooling_device_ops powerclamp_cooling_ops = {
> +static const struct thermal_cooling_device_ops
> powerclamp_cooling_ops = {
> Â	.get_max_state = powerclamp_get_max_state,
> Â	.get_cur_state = powerclamp_get_cur_state,
> Â	.set_cur_state = powerclamp_set_cur_state,