Re: [PATCH] trace-listen: add missing header

From: Baruch Siach
Date: Thu Jun 29 2017 - 08:30:55 EST


Hi Steven,

On Thu, Jun 29, 2017 at 08:19:56AM -0400, Steven Rostedt wrote:
> On Thu, 29 Jun 2017 14:46:21 +0300
> Baruch Siach <baruch@xxxxxxxxxx> wrote:
>
> > The PATH_MAX macro requires the limits.h header. This fixes build with musl
> > libc:
> >
> > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c: In function âmake_pid_nameâ:
> > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c:167:16: error: âPATH_MAXâ undeclared (first use in this function)
> > snprintf(buf, PATH_MAX, VAR_RUN_DIR "/trace-cmd-net.pid");
> > ^~~~~~~~
>
> Thanks! I have a few other patches that need to go into trace-cmd. I'll
> try to get to that today or tomorrow.

There is no rush.

By the way, using both MAX_PATH (local) and PATH_MAX (system) macros in the
same file might bite at some point. Also, MAX_PATH has different values in
different files.

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@xxxxxxxxxx - tel: +972.52.368.4656, http://www.tkos.co.il -