Re: [PATCH v2 4/8] objtool: add undwarf debuginfo generation

[Josh Poimboeuf]

On Thu, Jun 29, 2017 at 09:14:14AM +0200, Ingo Molnar wrote:
> 
> * Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> 
> > Now that objtool knows the states of all registers on the stack for each
> > instruction, it's straightforward to generate debuginfo for an unwinder
> > to use.
> > 
> > Instead of generating DWARF, generate a new format called undwarf, which
> > is more suitable for an in-kernel unwinder.  See
> > tools/objtool/Documentation/undwarf.txt for a more detailed description
> > of this new debuginfo format and why it's preferable to DWARF.
> > 
> > Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> > ---
> >  tools/objtool/Build                              |   3 +
> >  tools/objtool/Documentation/stack-validation.txt |  46 ++---
> >  tools/objtool/builtin-check.c                    |   2 +-
> >  tools/objtool/builtin-undwarf.c                  |  70 ++++++++
> >  tools/objtool/builtin.h                          |   1 +
> >  tools/objtool/check.c                            |  59 ++++++-
> >  tools/objtool/check.h                            |  15 +-
> >  tools/objtool/elf.c                              | 212 ++++++++++++++++++++--
> >  tools/objtool/elf.h                              |  15 +-
> >  tools/objtool/objtool.c                          |   3 +-
> >  tools/objtool/undwarf-types.h                    |  81 +++++++++
> 
> Just a very quick stylistic suggestion: please name the header 'undwarf_types.h' 
> (note the underscore versus hyphen), which is the common naming pattern used in 
> the kernel.

Ok, will rename it.

-- 
Josh