Re: [PATCH] EDAC: Get rid of mci->mod_ver

From: Thor Thayer
Date: Thu Jun 29 2017 - 09:55:13 EST


On 06/29/2017 05:03 AM, Borislav Petkov wrote:
Hi,

any objections?

---
It is a write-only variable so get rid of it.

Signed-off-by: Borislav Petkov <bp@xxxxxxx>
Cc: Thor Thayer <thor.thayer@xxxxxxxxxxxxxxx>
Cc: Mark Gross <mark.gross@xxxxxxxxx>
Cc: Robert Richter <rric@xxxxxxxxxx>
Cc: Tim Small <tim@xxxxxxxxxxxxxxxx>
Cc: Ranganathan Desikan <ravi@xxxxxxxxxxxxxxxxxxxx>
Cc: "Arvind R." <arvino55@xxxxxxxxx>
Cc: Jason Baron <jbaron@xxxxxxxxxx>
Cc: Tony Luck <tony.luck@xxxxxxxxx>
Cc: Michal Simek <michal.simek@xxxxxxxxxx>
Cc: "SÃren Brinkmann" <soren.brinkmann@xxxxxxxxxx>
Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
Cc: David Daney <david.daney@xxxxxxxxxx>
Cc: Loc Ho <lho@xxxxxxx>
Cc: linux-edac@xxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
Cc: linux-mips@xxxxxxxxxxxxxx
---
drivers/edac/altera_edac.c | 2 --

<snip>


diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
index db75d4b614f7..fa2e5db56d24 100644
--- a/drivers/edac/altera_edac.c
+++ b/drivers/edac/altera_edac.c
@@ -38,7 +38,6 @@
#include "edac_module.h"
#define EDAC_MOD_STR "altera_edac"
-#define EDAC_VERSION "1"
#define EDAC_DEVICE "Altera"

<snip>

Looks fine for Altera EDAC.

Acked-by: Thor Thayer <thor.thayer@xxxxxxxxxxxxxxx>