Re: [PATCH v1 2/2] drm: rcar-du: Repair vblank for DRM page flips using the VSP1

From: Kieran Bingham
Date: Thu Jun 29 2017 - 10:08:16 EST


> @@ -658,10 +660,14 @@ static irqreturn_t rcar_du_crtc_irq(int irq, void *arg)
> rcar_du_crtc_write(rcrtc, DSRCR, status & DSRCR_MASK);
>
> if (status & DSSR_FRM) {
> - drm_crtc_handle_vblank(&rcrtc->crtc);
> -
> - if (rcdu->info->gen < 3)
> + /*
> + * Gen 3 vblank and page flips are handled through the VSP
> + * completion handler
> + */
> + if (rcdu->info->gen < 3) {

Of course as is obvious immediately after hitting send, this check was supposed
to be removed now that the interrupt is not registered.

Sorry for the noise and pre-released patch!

--
Kieran