Re: [PATCH net] virtio-net: serialize tx routine during reset

From: David Miller
Date: Thu Jun 29 2017 - 12:52:53 EST


From: Jason Wang <jasowang@xxxxxxxxxx>
Date: Wed, 28 Jun 2017 09:51:03 +0800

> We don't hold any tx lock when trying to disable TX during reset, this
> would lead a use after free since ndo_start_xmit() tries to access
> the virtqueue which has already been freed. Fix this by using
> netif_tx_disable() before freeing the vqs, this could make sure no tx
> after vq freeing.
>
> Reported-by: Jean-Philippe Menil <jpmenil@xxxxxxxxx>
> Tested-by: Jean-Philippe Menil <jpmenil@xxxxxxxxx>
> Fixes commit f600b6905015 ("virtio_net: Add XDP support")
> Cc: John Fastabend <john.fastabend@xxxxxxxxx>
> Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>

Applied and queued up for -stable.