Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

[Bamvor Zhang Jian]

On 29 June 2017 at 19:39, Fathi Boudra <fathi.boudra@xxxxxxxxxx> wrote:
> On 29 June 2017 at 12:01, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
>> Fathi Boudra <fathi.boudra@xxxxxxxxxx> writes:
>>
>>> Fix hardcoded and misplaced libmount headers. Use pkg-config instead to
>>> figure out CFLAGS/LDLIBS, fixing also their value for cross-compilation.
>>
>> Can you explain how it fixes the values for cross-compilation?
>
> When pkg-config is invoked in a cross-build environment, it will
> return your sysroot headers path instead of the hardcoded
> -I/usr/include/libmount
>
> For example in my oe environment, when I invoke "pkg-config --cflags
> mount", it returns:
> -I/build/tmp-rpb-glibc/sysroots/hikey/usr/include/libmount
I suppose we could also pass the extra CFLAGS and LDFLAGS directly to
make it work. correct?

Regards

Bamvor
>
>> cheers
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html