RE: [PATCH] staging: fsl-dpaa2/eth: Remove dead code

From: Bogdan Purcareata
Date: Fri Jun 30 2017 - 03:19:51 EST


> -----Original Message-----
> From: Ioana Radulescu [mailto:ruxandra.radulescu@xxxxxxx]
> Sent: Thursday, June 29, 2017 7:26 PM
> To: gregkh@xxxxxxxxxxxxxxxxxxx
> Cc: devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> agraf@xxxxxxx; arnd@xxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Bogdan
> Purcareata <bogdan.purcareata@xxxxxxx>; stuyoder@xxxxxxxxx; Laurentiu Tudor
> <laurentiu.tudor@xxxxxxx>
> Subject: [PATCH] staging: fsl-dpaa2/eth: Remove dead code
>
> All possible values of the switch statement are explicitly
> handled, so there's no need to have a default branch.
>
> Signed-off-by: Ioana Radulescu <ruxandra.radulescu@xxxxxxx>

Acked-by: Bogdan Purcareata <bogdan.purcareata@xxxxxxx>

> ---
> drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> index 5312edc26f01..031179ab3a22 100644
> --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> @@ -217,8 +217,6 @@ static void dpaa2_eth_get_ethtool_stats(struct
> net_device *net_dev,
> case 2:
> num_cnt = sizeof(dpni_stats.page_2) / sizeof(u64);
> break;
> - default:
> - break;
> }
> for (k = 0; k < num_cnt; k++)
> *(data + i++) = dpni_stats.raw.counter[k];
> --
> 2.11.0